-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Implement VK_EXT_rasterization_order_attachment_access #2280
base: main
Are you sure you want to change the base?
WIP: Implement VK_EXT_rasterization_order_attachment_access #2280
Conversation
02ee15d
to
7e21006
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you make sure that input attachments are numbered correctly in the shader?
Thank you for taking a look! I was just prototyping under the assumption that The input attachments are numbered correctly in my own use case (which uses 4), but I haven't otherwise tested it. Since this internally enables framebuffer-fetch supbasses across the board, would the existing test suite be enough to ensure the color attachments are numbered correctly? |
Implement VK_EXT_rasterization_order_attachment_access using the "programmable blending" feature available on Apple family GPUs.
7e21006
to
7de4944
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the initiative and submitting this.
I've marked this as WIP, as it looks like there is work to do to get this working properly for general use cases.
I ran the rasterization_order_attachment_access
tests in CTS, and the results are here:
Test run totals:
Passed: 1/282 (0.4%)
Failed: 97/282 (34.4%)
Not supported: 184/282 (65.2%)
Warnings: 0/282 (0.0%)
Waived: 0/282 (0.0%)
Details are here: rasterization_order_attachment_access-results.txt.zip
Implement VK_EXT_rasterization_order_attachment_access using the "programmable blending" feature available on Apple family GPUs.