Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: KHR_calibrated_timestamp #2110

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

spnda
Copy link
Collaborator

@spnda spnda commented Dec 30, 2023

Tiny change to add the promoted extension with no changes. Depends on #2109 for the Vulkan-Headers update.

I should've probably combined this change in the same PR #2109, but I'll keep this open now. When #2109 is merged I'll force push this branch to trigger CI to re-run, as its currently just failing on the outdated Vulkan-Headers.

@spnda spnda requested a review from billhollings December 30, 2023 04:28
@spnda spnda force-pushed the KHR_calibrated_timestamp branch 2 times, most recently from bb2f300 to 6f29fcb Compare January 1, 2024 03:32
MoltenVK/MoltenVK/Vulkan/vulkan.mm Outdated Show resolved Hide resolved
Copy link
Contributor

@billhollings billhollings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this.

Looks good, but can you make the aliasing change that @cdavis5e suggested, please?

MoltenVK/MoltenVK/Vulkan/vulkan.mm Outdated Show resolved Hide resolved
@spnda spnda force-pushed the KHR_calibrated_timestamp branch from 6f29fcb to 6e94ff0 Compare January 3, 2024 06:58
@spnda spnda requested review from billhollings and cdavis5e January 3, 2024 07:00
Copy link
Contributor

@billhollings billhollings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@billhollings billhollings merged commit ae073e7 into KhronosGroup:main Jan 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants