Fix rare deadlock during launch via dlopen(). #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan-lunarg
reviewed
Nov 15, 2023
cdavis5e
requested changes
Nov 16, 2023
|
I was hopeful when I saw this PR that it would fix a problem I've encountered with Qt frameworks that just started two releases ago. There's a deadlock somewhere (and Qt is using Metal for it's own GUI) as the GUI never shows up, although the render loop runs, and there are no validation errors. The error I'm encountering happens if I link statically, or use the Loader. This is a good fix, I'm just putting out there that there may be more deadlocks like this floating around. |
- Don't create global MVKPixelFormats instance during launch, as this triggers a call to MTLCopyAllDevices(), which can deadlock if app is also launching other services that use Metal.
billhollings
force-pushed
the
fix-rare-dlopen-deadlock
branch
from
5f2c522 to
037ac4b
Compare
Thanks for reporting it. Uggh. If you have more info about the Qt deadlock, can you open another issue focused on it, please? |
juan-lunarg
reviewed
Nov 17, 2023
cdavis5e
approved these changes
Nov 17, 2023
juan-lunarg
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MVKPixelFormatsinstance during launch, as this triggers a call toMTLCopyAllDevices(), which can deadlock if app is also launching other services that use Metal.Fixes #2050.