Add support for VK_EXT_extended_dynamic_state3 extension. #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2023
cdavis5e
requested changes
Nov 16, 2023
- Move patch point tracking from pipeline state to render state, and remove MVKPipelineCommandEncoderState subclasses no longer needed. - Move sample location tracking from renderpass input to pipeline static or dynamic state tracking. - Restart Metal render pass when sample locations change, and enable VkPhysicalDeviceSampleLocationsPropertiesEXT::variableSampleLocations. - Fix regression that broke VK_POLYGON_MODE_LINE (unrelated). - Fix regression in marking MVKRenderingCommandEncoderState dirty after vkCmdClearAttachments() (unrelated).
billhollings
force-pushed
the
EXT_extended_dynamic_state3
branch
from
e89adc7 to
13998af
Compare
Thanks for the feedback. Should be cleaned up now. |
cdavis5e
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MVKPipelineCommandEncoderStatesubclasses no longer needed.VkPhysicalDeviceSampleLocationsPropertiesEXT::variableSampleLocations.VK_POLYGON_MODE_LINE(unrelated).MVKRenderingCommandEncoderStatedirty aftervkCmdClearAttachments()(unrelated).This PR includes fixes for issues #2056 and #2057.