Fixes to determination of VkPhysicalDeviceLimits::timestampPeriod. #2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 17, 2023
- On Apple GPUs, set timestampPeriod to 1.0. - On non-Apple GPUs, calculate timestampPeriod each time it is retrieved. - On older devices that do not support GPU timestamps, use nanosecond CPU timestamps to be consistent with timestampPeriod of 1.0. - Change MVKConfiguration::timestampPeriodLowPassAlpha and environment variable MVK_CONFIG_TIMESTAMP_PERIOD_LOWPASS_ALPHA to 1.0, to use only latest value by default. - Add build-time verification that MVKConfigMembers.def includes all members of MVKConfiguration (unrelated).
billhollings
force-pushed
the
fix-timestampPeriod
branch
from
e6863e8 to
3a77f4e
Compare
cdavis5e
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timestampPeriodto 1.0.timestampPeriodeach time it is retrieved.timestampPeriodof 1.0.MVKConfiguration::timestampPeriodLowPassAlphaand environment variableMVK_CONFIG_TIMESTAMP_PERIOD_LOWPASS_ALPHAto1.0, to use only latest value by default.MVKConfigMembers.defincludes all members ofMVKConfiguration(unrelated).Fixes issue #2039.
Fixes issue #2040.