Remove project qualifiers from references to SPIRV-Cross and glslang header files. #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…header files. Remove SPIRV-Cross/ qualifier from include references to SPIRV-Cross header files. Remove glslang/ qualifier from include references to glslang header files. This change allows easier integration with app build scripts.
SpaceIm
reviewed
Mar 1, 2021
There was a problem hiding this comment.
@billhollings glslang qualifier shouldn't be removed.
glslang installs its public headers under <include install dir>/glslang, and defines <include install dir> as include directory:
https://github.com/KhronosGroup/glslang/blob/e04a046ce7c2ce6d37cc7a28802c167d84ffabf3/glslang/CMakeLists.txt#L174
https://github.com/KhronosGroup/glslang/blob/e04a046ce7c2ce6d37cc7a28802c167d84ffabf3/glslang/CMakeLists.txt#L215-L224
Otherwise, LGTM for spirv-cross
MoltenVKShaderConverter/MoltenVKShaderConverter.xcodeproj/project.pbxproj
Show resolved
Hide resolved
MoltenVKShaderConverter/MoltenVKShaderConverter/GLSLToSPIRVConverter.cpp
Outdated
Show resolved
Hide resolved
|
Well, I was waiting for @SpaceIm, so 🤷♂️ . |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
SPIRV-Cross/qualifier from include references to SPIRV-Cross header files.Remove
glslang/qualifier from include references to glslang header files.This change allows easier integration with app build scripts.
Fixes issue #1279.