Handle double args intact #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current code join arg like ["-isystem", "/usr/..."] to ["-isystem /usr/..."]. This merging cause clang to fail to parse the path properly. To reproduce: $ clang -xc --verbose -c "-isystem /usr" /dev/null clang version 4.0.0 (tags/RELEASE_400/final) Target: x86_64-pc-linux-gnu ... clang -cc1 version 4.0.0 based upon LLVM 4.0.0 default target x86_64-pc-linux-gnu ignoring nonexistent directory " /usr" ... As shown in the output, it tries to lookup " /usr", instead of "/usr". Clang-3.8.0 also behave as the same: https://wandbox.org/permlink/Iyxjqbg6tE9Nr5qs Thus, the commit properly handle such double argument, not joining them with space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code join arg like ["-isystem", "/usr/..."] to ["-isystem /usr/..."]. This merging cause clang to fail to parse the path properly.
To reproduce:
$ clang -xc --verbose -c "-isystem /usr" /dev/null
clang version 4.0.0 (tags/RELEASE_400/final)
Target: x86_64-pc-linux-gnu
...
clang -cc1 version 4.0.0 based upon LLVM 4.0.0 default target x86_64-pc-linux-gnu
ignoring nonexistent directory " /usr"
...
As shown in the output, it tries to lookup " /usr", instead of "/usr".
Clang-3.8.0 also behave as the same: https://wandbox.org/permlink/Iyxjqbg6tE9Nr5qs
Thus, the commit properly handle such double argument, not joining them with space.