Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20250202/bidirectional-layered-architecture 김도훈 기술블로그 제출 #122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

20250202/bidirectional-layered-architecture 김도훈 기술블로그 제출 #122

wants to merge 1 commit into from

Conversation

dona722
Copy link

@dona722 dona722 commented Feb 2, 2025

No description provided.

baki-719
baki-719 reviewed Feb 5, 2025
View reviewed changes
Copy link

@baki-719 baki-719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 도훈님

우선 리뷰가 늦어서 죄송합니다.
그래도 도훈님이 글을 잘 쓰신건지 술술 읽혀서 금방 읽었습니다.

굳이 좀 더 개선을 하려면 어떻걸 수정해야할까 해서 보면
예시부분이 조금 아쉬운거 같네요

Request같은 dto를 참조 하는 경우만 예시를 들었는데
단순 dto의 참조 외에 service에서 controller를 참조하는 그런 경우가 진짜 문제거든요
이런 상황을 한번 만들어보고 어떤 문제가 있는지 파악해서 에시에 추가해주면 좋을꺼 같습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baki-719 baki-719 baki-719 left review comments

@day1companyhaewooklee day1companyhaewooklee Awaiting requested review from day1companyhaewooklee day1companyhaewooklee is a code owner

@day1chan99k day1chan99k Awaiting requested review from day1chan99k day1chan99k is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dona722 @baki-719