Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] 추천 사용자4명, 상대방 프로필 이미지 전달 #248 #254

Merged
merged 2 commits into from
Feb 10, 2025
Merged

[Fix] 추천 사용자4명, 상대방 프로필 이미지 전달 #248 #254

merged 2 commits into from
Feb 10, 2025

Conversation

yr0202
Copy link
Collaborator

@yr0202 yr0202 commented Feb 9, 2025 •
edited
Loading

🚀 Pull Request

  • 추천 사용자 5명-> 4명
  • 추천 사용자 프로필 이미지 변경

#️⃣ 연관된 이슈

📋 작업 내용

🔧 변경된 코드 설명

  • 추천 사용자 프로필 이미지가 본인 프로필 이미지가 전달되고 있었는데, 상대방 프로필 이미지로 변경
  • 추천 사용자 5명에서 4명으로 수정

✅ 테스트 여부

  • 테스트 코드 실행 여부
  • 서버 실행 여부
  • 스웨거 테스트 여부

👽 비고

기타 알림 사항이 있으면 적어주세요.

@yr0202 yr0202 added the bug Something isn't working label Feb 9, 2025
@yr0202 yr0202 self-assigned this Feb 9, 2025
@yr0202 yr0202 linked an issue Feb 9, 2025 that may be closed by this pull request
[Fix] 추천 사용자 수 변경 & 프로필 이미지 수정 #248
Closed
yschoi123
yschoi123 previously approved these changes Feb 9, 2025
View reviewed changes
Copy link
Collaborator

@yschoi123 yschoi123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sukmo88
sukmo88 previously approved these changes Feb 10, 2025
View reviewed changes
@yr0202 yr0202 dismissed stale reviews from sukmo88 and yschoi123 via 4b7d5ec February 10, 2025 04:20
yschoi123
yschoi123 approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@yschoi123 yschoi123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yr0202 yr0202 requested a review from sukmo88 February 10, 2025 05:46
@yschoi123 yschoi123 merged commit db7905d into dev Feb 10, 2025
2 checks passed
@yschoi123 yschoi123 deleted the fix/matching-change-4people-#248 branch February 10, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukmo88 sukmo88 sukmo88 approved these changes

@yschoi123 yschoi123 yschoi123 approved these changes

Assignees

@yr0202 yr0202

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] 추천 사용자 수 변경 & 프로필 이미지 수정
3 participants
@yr0202 @sukmo88 @yschoi123