refactor: 진행 중인 경기 matchid 기준으로 정렬 #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I-migi
approved these changes
Dec 20, 2024
| @@ -98,6 +99,7 @@ public MatchInfo.SetScoreDetails retrieveAllSetsScoreInMatch(Long leagueId, Long | |||
| public List<LeagueSetsScoreInProgressInfo> retrieveLeagueMatchSetsScoreInProgress(Long leagueId) { | |||
| List<LeagueSetsScoreInProgressInfo> inProgressSet = setRepository.getInProgressSet(leagueId); | |||
| if (!inProgressSet.isEmpty()) { | |||
| inProgressSet.sort(Comparator.comparing(LeagueSetsScoreInProgressInfo::matchId)); | |||
There was a problem hiding this comment.
캐시가 없을 때는 retrieveLeagueMatchInProgress 에서 Comparing.sort를 사용해서 정렬이 되었었는데
캐시가 있을 때는 따로 정렬 함수가 없어서 데이터가 일정하게 나오지 않았나봐요!!
There was a problem hiding this comment.
맞아요! 정렬하는 부분을 놓쳤습니다 🤣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR에 대한 설명 🔍
캐시가 있을 때 match id 기준으로 정렬하여 응답합니다.
변경된 사항 📝
response를 정렬했습니다.
Before
After
PR에서 중점적으로 확인되어야 하는 사항