refactor: add a member policy when start match #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
km2535
approved these changes
Dec 5, 2024
| ) { | ||
| StartMatchCommand startMatchCommand = | ||
| new StartMatchCommand(clubToken, leagueId, matchId); | ||
| clubMemberPolicy.validateLeagueParticipant(leagueId, member.getMemberToken()); |
| throw new LeagueParticipantsNotExistsException(matchId); | ||
| throw new LeagueParticipantNotDeterminedException(matchId); |
There was a problem hiding this comment.
경기 참여자가 존재하지 않는다 -> 라는 게 조금 모호한 것 같아요. 해당 예외는 부전승 경기에서 아직 나머지 짝꿍이 정해지지 않았을 때 Match 를 시작하려고 하거나, 점수를 올리려고 할 때 나는 예외입니다. 따라서 상대 경기 참여자가 아직 결정되지 않았다는 의미를 더해 바꾸게 되었습니다.
I-migi
reviewed
Dec 5, 2024
Comment on lines
8
to
15
| public LeagueParticipantsNotExistsException(Long matchId) { | ||
| super(ErrorCode.LEAGUE_PARTICIPANTS_NOT_EXISTS, "[매치 ID : " + matchId + "]"); | ||
| super(ErrorCode.LEAGUE_NOT_PARTICIPATED, "[매치 ID : " + matchId + "]"); | ||
| } | ||
|
|
||
| public LeagueParticipantsNotExistsException(Long matchId, Exception e) { | ||
| super(ErrorCode.LEAGUE_PARTICIPANTS_NOT_EXISTS, "[매치 ID : " + matchId + "]", e); | ||
| super(ErrorCode.LEAGUE_NOT_PARTICIPATED, "[매치 ID : " + matchId + "]", e); | ||
| } | ||
| } |
There was a problem hiding this comment.
이 커스텀 예외의 네임만 보고 내가 이 경기에 참가하지 않아서 나는 예외인지, 이 경기에 아직 참가자가 존재하지 않아서 나는 예외인지 모호한 것 같아요!
There was a problem hiding this comment.
LeagueNotParticipatedException으로 바꿔야겠네요!
soeunnPark
deleted the
522-refactor-add-a-member-policy-when-start-match
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR에 대한 설명 🔍
start match를 하려면 경기 참여를 한 사용자여야 합니다.
변경된 사항 📝
PR에서 중점적으로 확인되어야 하는 사항