chore : 로그인 시 '로그인중..' 글자로 바꾸고 버튼 배경색 살짝 연해지도록 디자인 변경 #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
smosco
approved these changes
Dec 16, 2024
src/app/(fullscreen)/login/page.tsx
Outdated
Comment on lines
40
to
46
| <div className="relative min-h-screen bg-gradient-to-br from-indigo-50 to-violet-50 flex flex-col items-center justify-center p-4"> | ||
| {isLoading && ( | ||
| <div className="absolute inset-0 flex justify-center items-center z-50"> | ||
| <LoadingSpinner /> | ||
| </div> | ||
| )} | ||
| <div className={`max-w-md w-full space-y-8 ${isLoading && 'opacity-50'}`}> |
There was a problem hiding this comment.
전체 로딩 스피너보다는 각 버튼 옆에 작게 흰색으로 로딩 스피너를 보여주는 게 좋을 것 같아요
There was a problem hiding this comment.
스피너 대신 버튼 자체의 텍스트를 변경하고 배경색을 연하게 만드는 방법으로 변경했습니다
smosco
approved these changes
Dec 16, 2024
src/app/(fullscreen)/login/page.tsx
Outdated
Comment on lines
83
to
85
| {KakaoIsLoading && ( | ||
| <LoadingSpinner size="small" className="absolute right-1/4" /> | ||
| )} |
There was a problem hiding this comment.
네엡 스피너 대신 버튼 자체의 텍스트를 변경하고 배경색을 연하게 만드는 방법으로 변경했습니다
godhyzzang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Description of the PR
🔧 What has been changed?
📸 Screenshots / GIFs (if applicable)
✅ Checklist