Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: mypage에도 prefetchQuery적용, design : 홈 캐러셀 글자 문구, 디자인 수정 #415

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

godhyzzang
Copy link
Collaborator

📄 Description of the PR

  • 기능 설명 : refactor: mypage에도 prefetchQuery적용, design : 홈 캐러셀 글자 문구, 디자인 수정

  • Close [refactor] apply prefetchQuery on mypage #414

  • refactor : 마이페이지에도 prefetchQuery적용

  • design : 홈 캐러셀 글자 문구, 디자인 수정

🔧 What has been changed?

📸 Screenshots / GIFs (if applicable)

image

⚠️ Precaution & Known issues

✅ Checklist

  • UI 브랜치 같이 확인해서 이슈없는지 확인해보기
  • 함수 이름, 변수 이름만 봐도 어떤 기능을 하는지 파악할 수 있는지 (선언적인 코드인지 확인)

@godhyzzang godhyzzang requested a review from smosco December 16, 2024 05:06
@godhyzzang godhyzzang self-assigned this Dec 16, 2024
@godhyzzang godhyzzang linked an issue Dec 16, 2024 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@smosco smosco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

export const fetchAllCategories = async (): Promise<FetchCategoryResponse> => {
export const fetchAllCategories = async (
customHeaders?: Record<string, string>,
): Promise<FetchCategoryResponse> => {
return apiClient<FetchCategoryResponse>('/categories/all', {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

폐기된 api 같아요~
리딩 리스닝 나뉘어서요!

Comment on lines +19 to +28
await Promise.allSettled([
queryClient.prefetchQuery({
queryKey: ['user'],
queryFn: () => fetchUserInfo({ Cookie: cookieHeader }),
}),
queryClient.prefetchQuery({
queryKey: ['categories'],
queryFn: () => fetchAllCategories({ Cookie: cookieHeader }),
}),
]);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

에러 처리 되어 있는지 확인해주세요~

@smosco smosco merged commit b17e107 into develop Dec 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor] apply prefetchQuery on mypage
2 participants