Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : contentType에서 url이동하기 전에 카테고리 색깔 변경되는 문제 해결 #373

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

godhyzzang
Copy link
Collaborator

@godhyzzang godhyzzang commented Dec 6, 2024

📄 Description of the PR

🔧 What has been changed?

문제

contentType에서 url이동하기 전에 카테고리 색깔 변경되는 문제

해결

  • url에서 categoryId를 가져온 후 이를 state로 추가로 관리하는 방식에서 일어난 문제였습니다.
  • state코드 자체를 삭제하고 url에서 직접 가져온 currentcategoryId===카테고리 id 일때 category button의 색깔이 바뀌도록 만들었습니다.

📸 Screenshots / GIFs (if applicable)

before

url변경되기전에카테고리색깔바뀌는문제

after

url바뀌고나서야카테고리색깔도바뀜

⚠️ Precaution & Known issues

✅ Checklist

  • UI 브랜치 같이 확인해서 이슈없는지 확인해보기
  • 함수 이름, 변수 이름만 봐도 어떤 기능을 하는지 파악할 수 있는지 (선언적인 코드인지 확인)

@godhyzzang godhyzzang self-assigned this Dec 6, 2024
@godhyzzang godhyzzang linked an issue Dec 6, 2024 that may be closed by this pull request
3 tasks
@godhyzzang godhyzzang requested a review from smosco December 6, 2024 08:01
Copy link
Collaborator

@smosco smosco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다~

@smosco smosco merged commit 65472e3 into develop Dec 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] fix contentTypeFilter component logic
2 participants