Update User Audit Scripts for Pagination #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hingandh
reviewed
Oct 2, 2024
User Audit/useraudit.py
Outdated
| base_url = "https://api.kennasecurity.com" | ||
| users_url= base_url + "/users" | ||
| # increase per_page to get more data per request | ||
| per_page = 10 |
There was a problem hiding this comment.
can this be configurable like user can adjust this number?
There was a problem hiding this comment.
these scripts are sent to the client so either CX or client can customize the scripts. I have added a small README snippet about per_page but I do not see the need to make it a CLI option. I do not like the way CLI is being used in user audit script but not planning to change it
jaredkalmus
approved these changes
Oct 2, 2024
hingandh
approved these changes
Oct 3, 2024
macesped
reviewed
Oct 3, 2024
| @@ -33,5 +33,8 @@ You can set an environment variable in Windows using the setx command in the com | |||
| In macOS or Linux, you can set an environment variable in the terminal using the export command: | |||
| *export API_KEY=your-api-key* | |||
|
|
|||
| ### 4. Pagination Size | |||
There was a problem hiding this comment.
Nitpick: this should go after # 3. Also, it should keep the same format: 4:.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VM-5208
The script will work for both paginated and unpaginated API.
paginated response for useraudit.py
for audit script
