Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GL_RGB --> GL_RGBA8 #824

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change GL_RGB --> GL_RGBA8 #824

wants to merge 1 commit into from

Conversation

MegaMech
Copy link
Contributor

@MegaMech MegaMech commented Feb 22, 2025

This seems to be a spelling error since the other renderers use rgba8 or some variation of (bgra8).

This change will be necessary if the colour id framebuffer were to be implemented as it's based on a uint32_t instead of a 24 bit value.

@Archez
Copy link
Contributor

Archez commented Feb 23, 2025

These changes cause a significant difference in how OpenGL appears to render transparent textures: Example
image
The clouds on the map are darkened, the HUD A and C buttons are darkened. Water boxes, road paths, etc are all darkened.

This is how it looked before the changes:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants