Clean up some now unused stuff in dxgi #813
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
please make a testing PR on a port (and cross link them) so people can verify this |
|
Testbuild: HarbourMasters/Shipwright#5024 |
|
Converting to a draft for now, as I need to test "flush" situation more. The results of my quick tests where inconsistent. |
I should have done that a year ago...
gfx_d3d11_end_frame() already includes flushing, which comes right before gfx_dxgi_swap_buffers_begin() gets called.
|
Seems to be good without the flushing. I need to hold back not to also remove this flush here libultraship/src/graphic/Fast3D/gfx_direct3d11.cpp Lines 833 to 835 in 02bb77e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I should have done that ages ago...
Should not change any behavior. But as always: please test before merging.