Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw mouse input support #798

Merged
merged 9 commits into from
Feb 21, 2025
Merged

Conversation

lightmanLP
Copy link
Contributor

@lightmanLP lightmanLP commented Jan 25, 2025

Mouse capture uses raw input now.
P.S.: also fixes mouse delta inconsistency with opengl, when mouse capture is disabled

Test build:
https://github.com/lightmanLP/2ship2harkinian/tree/raw-mouse-input-test
https://github.com/lightmanLP/2ship2harkinian/actions/runs/12960612950

co-authored-by: @lilacLunatic

@lightmanLP lightmanLP marked this pull request as ready for review January 25, 2025 02:47
@MegaMech
Copy link
Contributor

MegaMech commented Feb 7, 2025

Tested on [content deleted] using DX, and OpenGL with SetMouseCapture on/off, and it works

@briaguya-ai
Copy link
Collaborator

the PR description has

P.S.: also fixes mouse delta inconsistency with opengl, when mouse capture is disabled

but the only file changed in this PR is gfx_dxgi.cpp. is that change in a different PR?

@lightmanLP
Copy link
Contributor Author

lightmanLP commented Feb 15, 2025

I meant that current DX implementation is inconsistent with OpenGL one, because DX implementation should also return mouse delta, when mouse capture is disabled.
So the fix only required changes on the DX side.

@briaguya-ai briaguya-ai merged commit 6f1461e into Kenix3:main Feb 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants