Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose tex clear funcs and fix more Metal issues with blended textures (cherry-pick) #409

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

Archez
Copy link
Contributor

@Archez Archez commented Jan 5, 2024

This exposes the texture cache clearing func so that it can be used outside of draw commands. I also added and exposed an unregister blended texture effect so that they can be cleaned up when not needed.

Additionally I resolved another issue with Metal shaders not working properly with blended effects, where the "last bound" textures on the frame buffer specifically for the mask and blended texture IDs were not cleared compared to DirectX.

Used with HarbourMasters/Shipwright#3773

(cherry-picked from 96c8a89)

Kenix3#408)

* expose tex cache delete

* add unregister blended texture method

* fix metal blended texture clearing

(cherry picked from commit 96c8a89)
@Kenix3
Copy link
Owner

Kenix3 commented Jan 22, 2024

Thankyou for the cherry pick!

@Kenix3 Kenix3 merged commit 36f114c into Kenix3:main Jan 22, 2024
4 checks passed
@Archez Archez deleted the cherrypick-texture-blend-fix branch September 13, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants