Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(.github): mismatch between CPU chip and binary name on macOS #401

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix(.github): mismatch between CPU chip and binary name on macOS #401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/release.yaml
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
the runner of "actions-rs/toolchain@v1" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]

commitlint-rs/.github/workflows/release.yaml

Line 48 in 547eff6

- uses: actions-rs/toolchain@v1

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
the runner of "actions-rs/toolchain@v1" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]

commitlint-rs/.github/workflows/release.yaml

Line 69 in 547eff6

- uses: actions-rs/toolchain@v1

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
the runner of "actions-rs/toolchain@v1" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]

commitlint-rs/.github/workflows/release.yaml

Line 141 in 547eff6

- uses: actions-rs/toolchain@v1

Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ jobs:
rust_target: x86_64-unknown-linux-gnu
ext: ""
args: ""
- os: macos-latest
- os: macos-13 (Intel x86)
rust_target: x86_64-apple-darwin
ext: ""
args: ""
- os: macos-14 # beta (Apple Silicon)
- os: macos-latest (Apple Silicon)
rust_target: aarch64-apple-darwin
ext: ""
Comment on lines +29 to 35
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Critical: Fix invalid runner syntax in matrix configuration

The current runner specifications contain invalid syntax that will cause workflow failures. GitHub Actions requires exact runner labels without parentheses.

Apply this correction:

-          - os: macos-13 (Intel x86)
+          - os: macos-13  # Intel x86
            rust_target: x86_64-apple-darwin
            ext: ""
            args: ""
-          - os: macos-latest (Apple Silicon)
+          - os: macos-latest  # Apple Silicon
            rust_target: aarch64-apple-darwin
            ext: ""
            args: ""

This change:

  1. Uses the correct runner labels that GitHub Actions expects
  2. Maintains architecture information as comments
  3. Preserves the intended mapping between runners and rust targets
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- os: macos-13 (Intel x86)
rust_target: x86_64-apple-darwin
ext: ""
args: ""
- os: macos-14 # beta (Apple Silicon)
- os: macos-latest (Apple Silicon)
rust_target: aarch64-apple-darwin
ext: ""
- os: macos-13 # Intel x86
rust_target: x86_64-apple-darwin
ext: ""
args: ""
- os: macos-latest # Apple Silicon
rust_target: aarch64-apple-darwin
ext: ""

args: ""
Expand Down
Loading