[SPIRV] simplify FileTest. (microsoft#5673)

Remove unused method for runFileTest and enable validation for all
tests. This will help code review when convert to lit FileCheck test.

tools/clang/unittests/SPIRV/CodeGenSpirvTest.cpp

@@ -583,8 +583,8 @@ TEST_F(FileTest, InheritanceLayoutEmptyStruct) {
   runFileTest("oo.inheritance.layout.empty-struct.hlsl");
 }
 TEST_F(FileTest, InheritanceCallMethodOfBase) {
-  runFileTest("oo.inheritance.call.base.method.hlsl", Expect::Success,
-              /* runValidation */ false);
+  setBeforeHLSLLegalization();
+  runFileTest("oo.inheritance.call.base.method.hlsl", Expect::Success);
 }
 TEST_F(FileTest, InheritanceBaseWithByteAddressBuffer) {
   runFileTest("oo.inheritance.base-with-byte-address-buffer.hlsl");
@@ -1752,13 +1752,12 @@ TEST_F(FileTest, AutoShiftBindings) {
 
 TEST_F(FileTest, BindingStructureOfResourcesOptimized) {
   // After optimization is performed, this binary should pass validation.
-  runFileTest("vk.binding.global-struct-of-resources.optimized.hlsl",
-              Expect::Success, /*runValidation*/ true);
+  runFileTest("vk.binding.global-struct-of-resources.optimized.hlsl");
 }
 
 TEST_F(FileTest, BindingStructureOfResourcesAndNonResourcesError1) {
   runFileTest("vk.binding.global-struct-of-resource-mix.error.1.hlsl",
-              Expect::Failure, /*runValidation*/ false);
+              Expect::Failure);
 }
 
 TEST_F(FileTest, BindingStructureOfResourcesAndNonResourcesError2) {
@@ -1773,8 +1772,7 @@ TEST_F(FileTest, BindingStructureOfResourcesContainsBufferError) {
 }
 TEST_F(FileTest, BindingStructureOfResourcesPassLegalization) {
   runFileTest("vk.binding.global-struct-of-resources.pass-legalization.hlsl",
-              Expect::Success,
-              /*runValidation*/ true);
+              Expect::Success);
 }
 
 TEST_F(FileTest, VulkanPushConstant) { runFileTest("vk.push-constant.hlsl"); }
@@ -2161,14 +2159,10 @@ TEST_F(FileTest, MeshShadingNVMeshError14) {
   runFileTest("meshshading.nv.error14.mesh.hlsl", Expect::Failure);
 }
 TEST_F(FileTest, MeshShadingNVAmplification) {
-  // TODO: Re-enable spirv-val once issue#3006 is fixed.
-  runFileTest("meshshading.nv.amplification.hlsl", Expect::Success,
-              /* runValidation */ false);
+  runFileTest("meshshading.nv.amplification.hlsl", Expect::Success);
 }
 TEST_F(FileTest, MeshShadingNVAmplificationFunCall) {
-  // TODO: Re-enable spirv-val once issue#3006 is fixed.
-  runFileTest("meshshading.nv.fncall.amplification.hlsl", Expect::Success,
-              /* runValidation */ false);
+  runFileTest("meshshading.nv.fncall.amplification.hlsl", Expect::Success);
 }
 TEST_F(FileTest, MeshShadingNVAmplificationError1) {
   runFileTest("meshshading.nv.error1.amplification.hlsl", Expect::Failure);
@@ -2184,9 +2178,9 @@ TEST_F(FileTest, MeshShadingNVAmplificationError4) {
 }
 
 TEST_F(FileTest, UseRValueForMemberExprOfArraySubscriptExpr) {
+  setBeforeHLSLLegalization();
   runFileTest("use.rvalue.for.member-expr.of.array-subscript.hlsl",
-              Expect::Success,
-              /* runValidation */ false);
+              Expect::Success);
 }
 
 TEST_F(FileTest, ReduceLoadSize) { runFileTest("reduce.load.size.hlsl"); }

tools/clang/unittests/SPIRV/FileTestFixture.cpp

@@ -62,8 +62,8 @@ bool FileTest::parseCommand() {
   return true;
 }
 
-void FileTest::runFileTest(llvm::StringRef filename, Expect expect,
-                           bool runValidation) {
+void FileTest::runFileTest(llvm::StringRef filename, Expect expect) {
+  bool runValidation = true;
   if (beforeHLSLLegalization)
     assert(runValidation);
 

tools/clang/unittests/SPIRV/FileTestFixture.h

@@ -32,17 +32,13 @@ class FileTest : public ::testing::Test {
         glLayout(false), dxLayout(false) {}
 
   void setBeforeHLSLLegalization() { beforeHLSLLegalization = true; }
-  void setGlLayout() { glLayout = true; }
-  void setDxLayout() { dxLayout = true; }
-  void setScalarLayout() { scalarLayout = true; }
 
   /// \brief Runs a test with the given input HLSL file.
   ///
   /// The first line of HLSL code must start with "// RUN:" and following DXC
   /// arguments to run the test. Next lines must be proper HLSL code for the
   /// test. It uses file check style output check e.g., "// CHECK: ...".
-  void runFileTest(llvm::StringRef path, Expect expect = Expect::Success,
-                   bool runValidation = true);
+  void runFileTest(llvm::StringRef path, Expect expect = Expect::Success);
 
   /// \brief Runs a test with the given HLSL code.
   ///