Skip to content

Commit

Permalink
Remove the cargo department
Browse files Browse the repository at this point in the history
  • Loading branch information
babydoll committed Oct 15, 2017
1 parent 7c81199 commit 051c23b
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 26 deletions.
2 changes: 0 additions & 2 deletions code/game/jobs/job_controller.dm
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ var/global/datum/controller/occupations/job_master
GLOB.supply_positions |= job.title
if(job.department_flag & SRV)
GLOB.service_positions |= job.title
if(job.department_flag & CRG)
GLOB.cargo_positions |= job.title
if(job.department_flag & CIV)
GLOB.civilian_positions |= job.title
if(job.department_flag & MSC)
Expand Down
15 changes: 7 additions & 8 deletions code/game/jobs/jobs.dm
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,11 @@ var/const/MED =(1<<2)
var/const/SCI =(1<<3)
var/const/CIV =(1<<4)
var/const/COM =(1<<5)
var/const/CRG =(1<<6)
var/const/MSC =(1<<7)
var/const/SRV =(1<<8)
var/const/SUP =(1<<9)
var/const/SPT =(1<<10)
var/const/EXP =(1<<11)
var/const/MSC =(1<<6)
var/const/SRV =(1<<7)
var/const/SUP =(1<<8)
var/const/SPT =(1<<9)
var/const/EXP =(1<<10)

GLOBAL_LIST_EMPTY(assistant_occupations)

Expand All @@ -21,8 +20,6 @@ GLOBAL_LIST_EMPTY(medical_positions)

GLOBAL_LIST_EMPTY(science_positions)

GLOBAL_LIST_EMPTY(cargo_positions)

GLOBAL_LIST_EMPTY(civilian_positions)

GLOBAL_LIST_EMPTY(security_positions)
Expand All @@ -37,6 +34,8 @@ GLOBAL_LIST_EMPTY(support_positions)

GLOBAL_LIST_EMPTY(exploration_positions)

GLOBAL_LIST_EMPTY(unsorted_positions) // for nano manifest


/proc/guest_jobbans(var/job)
return ((job in GLOB.command_positions) || (job in GLOB.nonhuman_positions) || (job in GLOB.security_positions))
Expand Down
4 changes: 2 additions & 2 deletions code/game/machinery/pager.dm
Original file line number Diff line number Diff line change
Expand Up @@ -64,5 +64,5 @@
/obj/machinery/pager/medical
department = MED

/obj/machinery/pager/cargo
department = CRG
/obj/machinery/pager/cargo //supply
department = SUP
14 changes: 2 additions & 12 deletions code/modules/modular_computers/file_system/crew_record.dm
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ GLOBAL_VAR_INIT(arrest_security_status, "Arrest")
var/list/eng = new()
var/list/med = new()
var/list/sci = new()
var/list/car = new()
var/list/civ = new()
var/list/bot = new()
var/list/misc = new()
Expand Down Expand Up @@ -206,9 +205,6 @@ GLOBAL_VAR_INIT(arrest_security_status, "Arrest")
if(job.department_flag & EXP)
exp[name] = rank
department = 1
if(job.department_flag & CRG)
car[name] = rank
department = 1
if(job.department_flag & CIV)
civ[name] = rank
department = 1
Expand Down Expand Up @@ -268,11 +264,6 @@ GLOBAL_VAR_INIT(arrest_security_status, "Arrest")
for(var/name in sup)
dat += "<tr[even ? " class='alt'" : ""]><td>[mil_ranks[name]][name]</td><td>[sup[name]]</td><td>[isactive[name]]</td></tr>"
even = !even
if(car.len > 0)
dat += "<tr><th colspan=3>Cargo</th></tr>"
for(var/name in car)
dat += "<tr[even ? " class='alt'" : ""]><td>[mil_ranks[name]][name]</td><td>[car[name]]</td><td>[isactive[name]]</td></tr>"
even = !even
if(exp.len > 0)
dat += "<tr><th colspan=3>Exploration</th></tr>"
for(var/name in exp)
Expand Down Expand Up @@ -346,12 +337,11 @@ GLOBAL_VAR_INIT(arrest_security_status, "Arrest")
"eng" = filtered_nano_crew_manifest(GLOB.engineering_positions),\
"med" = filtered_nano_crew_manifest(GLOB.medical_positions),\
"sup" = filtered_nano_crew_manifest(GLOB.supply_positions),\
"car" = filtered_nano_crew_manifest(GLOB.cargo_positions),\
"exp" = filtered_nano_crew_manifest(GLOB.exploration_positions),\
"srv" = filtered_nano_crew_manifest(GLOB.service_positions),\
"bot" = silicon_nano_crew_manifest(GLOB.cargo_positions),\
"bot" = silicon_nano_crew_manifest(GLOB.nonhuman_positions),\
"civ" = filtered_nano_crew_manifest(GLOB.civilian_positions),\
"misc" = filtered_nano_crew_manifest(GLOB.cargo_positions)\
"misc" = filtered_nano_crew_manifest(GLOB.unsorted_positions)\
)

/proc/get_crewmember_record(var/name)
Expand Down
2 changes: 1 addition & 1 deletion code/procs/announce.dm
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ datum/announcement/proc/NewsCast(message as text, message_title as text)

if(job.department_flag & (COM | CIV | MSC))
return "Common"
if(job.department_flag & (SUP | CRG))
if(job.department_flag & SUP)
return "Supply"
if(job.department_flag & SPT)
return "Command"
Expand Down
2 changes: 1 addition & 1 deletion test/check-paths.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
set -e

WORLD_LOG_COUNT=46
ANGLE_BRACKET_COUNT=722
ANGLE_BRACKET_COUNT=721

FAILED=0

Expand Down

0 comments on commit 051c23b

Please sign in to comment.