Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Roact exhaustive dependencies lint #548

Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
69ecf12
Add roact exhaustive deps lint
chriscerie Aug 21, 2023
4a12b35
Fix clippy warnings
chriscerie Aug 21, 2023
2153279
Update test
chriscerie Aug 21, 2023
2bdbf77
Ignore setState variables
chriscerie Aug 21, 2023
9bc2441
Use if chain
chriscerie Aug 21, 2023
1f6f856
Use scope manager instead of manual AST traversal
chriscerie Aug 24, 2023
fdac1d2
Move getting upvalues to its own function
chriscerie Aug 24, 2023
cc278df
Ignore values defined outside component
chriscerie Aug 24, 2023
04e1513
Warn about unnecessary dependencies
chriscerie Aug 24, 2023
ebde350
Change lint name to non exhaustive
chriscerie Aug 27, 2023
2dd7cbf
Merge branch 'main' of https://github.com/Kampfkarren/selene into exh…
chriscerie Aug 27, 2023
fdeeb97
Warn against missing props in deps and add other known stables vars
chriscerie Aug 27, 2023
0f5e461
Handle complex indexing deps
chriscerie Sep 2, 2023
ed28d22
Flatten indentation
chriscerie Sep 2, 2023
57794a2
Merge branch 'main' into exhaustive-deps
chriscerie Sep 17, 2023
89e0e98
Merge branch 'exhaustive-deps' of https://github.com/chriscerie/selen…
chriscerie Sep 17, 2023
e2d36a1
Handle function calls
chriscerie Sep 20, 2023
7688e8e
Format
chriscerie Sep 20, 2023
db9b0f4
Warn about complex deps
chriscerie Sep 20, 2023
1a174ca
Add other hooks and tests
chriscerie Sep 20, 2023
690ab9a
Update docs and changelog
chriscerie Sep 20, 2023
6d9c062
Update docs
chriscerie Sep 20, 2023
95f18a9
Add more known stable functions
chriscerie Sep 20, 2023
dccb782
Update docs wording
chriscerie Oct 9, 2023
501d3b9
Merge branch 'main' into exhaustive-deps
chriscerie Oct 9, 2023
cfd5e79
Merge branch 'main' into exhaustive-deps
chriscerie Oct 21, 2023
851ae5a
Merge branch 'main' into exhaustive-deps
chriscerie Oct 26, 2023
23aa26f
Test
chriscerie Nov 4, 2023
c23ba11
Test
chriscerie Nov 4, 2023
786de0b
Test
chriscerie Nov 4, 2023
4d26ab3
Test
chriscerie Nov 4, 2023
1143c66
Merge branch 'main' into exhaustive-deps
chriscerie Nov 8, 2023
a0d53df
Merge branch 'main' of https://github.com/Kampfkarren/selene
chriscerie Nov 9, 2023
ab5467a
Merge branch 'main' into exhaustive-deps
chriscerie Nov 10, 2023
98176b5
Merge branch 'main' of https://github.com/Kampfkarren/selene
chriscerie Nov 11, 2023
6a2ae8b
Merge remote-tracking branch 'origin' into exhaustive-deps
chriscerie Nov 11, 2023
40cc2e8
Clean up
chriscerie Nov 11, 2023
b13afa6
Remove file
chriscerie Nov 11, 2023
df19364
Remove change
chriscerie Nov 11, 2023
2cdad1e
Fix docs
chriscerie Nov 11, 2023
0a8d47d
Fix clippy
chriscerie Nov 11, 2023
9b889c9
Merge branch 'main' of https://github.com/chriscerie/selene into exha…
chriscerie Dec 8, 2023
8611e22
Fix false positive in anonymous function components
chriscerie Dec 8, 2023
ca83993
Add test and comments
chriscerie Jan 7, 2024
2fc923e
Merge branch 'main' of https://github.com/Kampfkarren/selene into exh…
chriscerie Jan 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test
chriscerie committed Nov 4, 2023
commit 4d26ab37d04ca12d3465d46d8c504eeab6039b05
32 changes: 16 additions & 16 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,37 +1,37 @@
ARG RUST_VERSION="1"

FROM rust:${RUST_VERSION}-bullseye AS selene-builder
RUN apt-get update && \
apt-get upgrade -y && \
apt-get install g++ && \
cargo install --branch main --git https://github.com/Kampfkarren/selene selene

FROM rust:${RUST_VERSION}-bullseye AS selene-light-builder
RUN apt-get update && \
apt-get upgrade -y && \
apt-get install g++ && \
cargo install --no-default-features --branch main --git https://github.com/Kampfkarren/selene selene

FROM rust:${RUST_VERSION}-alpine AS selene-light-musl-builder
RUN apk add g++ && \
cargo install --no-default-features --branch main --git https://github.com/Kampfkarren/selene selene

FROM rust:${RUST_VERSION}-alpine AS selene-musl-builder
RUN apk add g++ && \
cargo install --branch main --git https://github.com/Kampfkarren/selene selene

FROM rust:${RUST_VERSION}-alpine AS selene-light-musl-builder
RUN apk add g++ && \
cargo install --no-default-features --branch main --git https://github.com/Kampfkarren/selene selene
FROM bash AS selene
COPY --from=selene-builder /usr/local/cargo/bin/selene /
CMD ["/selene"]

FROM bash AS selene-light
COPY --from=selene-light-builder /usr/local/cargo/bin/selene /
CMD ["/selene"]

FROM bash AS selene-musl
COPY --from=selene-musl-builder /usr/local/cargo/bin/selene /
CMD ["/selene"]

FROM bash AS selene-light-musl
COPY --from=selene-light-musl-builder /usr/local/cargo/bin/selene /
CMD ["/selene"]

FROM rust:${RUST_VERSION}-bullseye AS selene-builder
RUN apt-get update && \
apt-get upgrade -y && \
apt-get install g++ && \
cargo install --branch main --git https://github.com/Kampfkarren/selene selene

FROM bash AS selene
COPY --from=selene-builder /usr/local/cargo/bin/selene /
CMD ["/selene"]
FROM bash AS selene-musl
COPY --from=selene-musl-builder /usr/local/cargo/bin/selene /
CMD ["/selene"]