KUI-1256 - remove unused code/dependencies and fix eslint #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is only used as peerDependencies and those are installed automatically since npm 7 Source: https://github.blog/2021-02-02-npm-7-is-now-generally-available/\#peer-dependencies
We only use react-router-dom, which has react-router as dependency
ghost
approved these changes
Mar 15, 2024
belanglos
force-pushed
the
issues/KUI-1256
branch
from
c77f3af to
2c3f4be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unused code and unused dependencies (or peerDependencies that do not have to explicitly put into
dependenciesanymore).It also handles all eslint-errors.