feat(KUI-1135): add fallback without link when SU is course department #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 1, 2024 08:37
change course_department_link for SU
ghost
marked this pull request as ready for review
belanglos
approved these changes
Feb 1, 2024
| const { buildCourseDepartmentLink } = require('../courseDepartmentUtils') | ||
| const { INFORM_IF_IMPORTANT_INFO_IS_MISSING } = require('../constants') | ||
|
|
||
| function htmlStringToElement(html) { |
| expect(result).not.toBeDefined() | ||
| }) | ||
|
|
||
| test.each([undefined, { name: undefined }])('returns fallback text if department is %p', department => { |
There was a problem hiding this comment.
🥇 I had no idea this was possible \o/
| return courseDepartment.code === DEPARTMENT_CODE_STOCKHOLM_UNIVERSITY | ||
| } | ||
|
|
||
| function buildCourseDepartmentLink(courseDepartment, language) { |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we have a broken link when Stockholm university is course department. This PR adds a fallback that only display the course department name as text when SU is course department.
JIRA: KUI-1135