ref(KUI-1176): improve naming, remove duplicate code

KTH · May 21, 2024 · 9af196e · 9af196e
1 parent 2634e62
commit 9af196e
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/public/js/app/hooks/useSemesterRoundState.js b/public/js/app/hooks/useSemesterRoundState.js
@@ -24,18 +24,14 @@ const useSemesterRoundState = ({
 
   const resetSelectedRoundIndex = useCallback(() => setSelectedRoundIndex(() => UNSET_VALUE), [setSelectedRoundIndex])
 
-  const semesterOnlyHasOneRound = (rounds, semester) =>
+  const determineSemesterOnlyHasOneRound = (rounds, semester) =>
     rounds !== undefined &&
     Object.hasOwnProperty.call(rounds, semester) &&
     rounds[semester] &&
     rounds[semester].length === 1
 
   const activeSemesterOnlyHasOneRound = useMemo(
-    () =>
-      roundList !== undefined &&
-      Object.hasOwnProperty.call(roundList, selectedSemester) &&
-      roundList[selectedSemester] &&
-      roundList[selectedSemester].length === 1,
+    () => determineSemesterOnlyHasOneRound(roundList, selectedSemester),
     [roundList, selectedSemester]
   )
 
@@ -81,7 +77,7 @@ const useSemesterRoundState = ({
   const setSelectedSemesterAsNumber = useCallback(
     newActiveSemester => {
       setSelectedSemester(() => Number(newActiveSemester))
-      if (semesterOnlyHasOneRound(roundList, selectedSemester)) {
+      if (determineSemesterOnlyHasOneRound(roundList, selectedSemester)) {
         setSelectedRoundIndex(0)
       } else {
         resetSelectedRoundIndex()