-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a timewarp kraken, add MNA and ArgPe to simulation GUI options, and some other various simulation GUI changes #2494
base: master
Are you sure you want to change the base?
Conversation
since DateTime can ofc handle seconds
who would use this?
Also also remind the user that they can just specify time in seconds. |
Hm, on second thought, I think the format that is allowed should changed based on whether or not "From now" is selected. Otherwise, we could end up with some really wacky situations, where people put "1960-12-31" and accidentally hit "From now", resulting in them warping forward 1960 years. |
especially a problem with principia
is that some good code siimav? ill be stealing that, thank you very much
its argPe in the docs so this is a little better
Also added mean anomaly at epoch and argument of periapsis to the simulation gui. |
if we already tell the user what the minimum value is, then we dont need to set them so high above the atmosphere, as this could just be confusing. 5000 is more than high enough to counteract principia shenanigans, while still allowing the user to be in a low orbit by default
does this even work?
just increases the size of the simulation config box, not the tooltip
Fix #2364.
Currently, only inputting Hours:minutes:seconds into the simulation window passes through TryParseTimeString without any failures as expected, but this leads to some problem later down the line where the game starts timewarping rapidly (2364). This PR makes it so if the user is trying to specify a specific time, they must include the YYYY-MM-DD as well to avoid this error. (only putting in YYYY-MM-DD and not the HH:mm:ss is currently fine, as it just sets the time to midnight) All other formats should still work.
Also remind the user that they are allowed to specify seconds in that format, as it can be parsed perfectly fine.
RIP analemma