Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken version label in About dialog #4277

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

HebaruSan
Copy link
Member

Problem

The About dialog's version label no longer shows the version:

image

Cause

The labels on the About form all have hard coded sizes and are not auto-sized, and the version string is longer than it used to be (build number was added), so the version label is wrapping and then being truncated vertically.

Changes

  • Now all the of the About dialog's labels have AutoSize = true, so they'll always show their full contents
  • Now if you press the menu key while focused on a link label, the menu will appear under the link label instead of at the mouse cursor

Fixes #4276.

@HebaruSan HebaruSan added Bug Something is not working as intended Easy This is easy to fix GUI Issues affecting the interactive GUI labels Dec 13, 2024
@HebaruSan HebaruSan force-pushed the fix/about-version-label branch from b40166e to 22e3edc Compare December 13, 2024 02:05
@HebaruSan HebaruSan merged commit 4a232bd into KSP-CKAN:master Dec 13, 2024
3 checks passed
@HebaruSan HebaruSan deleted the fix/about-version-label branch December 13, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended Easy This is easy to fix GUI Issues affecting the interactive GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Version info not displayed in Help | About dialog box
1 participant