net: guard tcp_set_keepalive() to tcp sockets

Its possible to use RAW sockets to get a crash in tcp_set_keepalive() / sk_reset_timer() Fix is to make sure socket is a SOCK_STREAM one. Change-Id: Ieeb498a3e623cfcb54e1c865a3c0229e4acf1e87 Reported-by: Dave Jones <[email protected]> Signed-off-by: Eric Dumazet <[email protected]> Signed-off-by: David S. Miller <[email protected]>
KFire-Android · Aug 18, 2016 · e3c856b · e3c856b
1 parent cfc4e94
commit e3c856b
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/net/core/sock.c b/net/core/sock.c
@@ -644,7 +644,8 @@ int sock_setsockopt(struct socket *sock, int level, int optname,
 
 	case SO_KEEPALIVE:
 #ifdef CONFIG_INET
-		if (sk->sk_protocol == IPPROTO_TCP)
+		if (sk->sk_protocol == IPPROTO_TCP &&
+		    sk->sk_type == SOCK_STREAM)
 			tcp_set_keepalive(sk, valbool);
 #endif
 		sock_valbool_flag(sk, SOCK_KEEPOPEN, valbool);