Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken flamegraph #683

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Fix broken flamegraph #683

merged 4 commits into from
Nov 18, 2024

Conversation

lievenhey
Copy link
Contributor

No description provided.

@lievenhey lievenhey force-pushed the fix-broken-flamegraph branch from 1264007 to 0bd3ee4 Compare November 15, 2024 14:13
@lievenhey lievenhey linked an issue Nov 18, 2024 that may be closed by this pull request
@lievenhey lievenhey force-pushed the fix-broken-flamegraph branch from 0bd3ee4 to 6b254c0 Compare November 18, 2024 10:14
@lievenhey lievenhey requested a review from milianw November 18, 2024 10:14
@milianw
Copy link
Member

milianw commented Nov 18, 2024

lots of unrelated changes, please cleanup (esp. revert the foreach changes)

@lievenhey
Copy link
Contributor Author

what the hell? Where are those changes from. I just ran clang-format

Apparently when running X11 the flamgraph doesn't clear the background
correctly. This patch resets the background brush which clears the
background correctly.

fixes: #624
@lievenhey lievenhey force-pushed the fix-broken-flamegraph branch from 10917ee to 02d2670 Compare November 18, 2024 13:34
@milianw milianw merged commit b0e70bf into master Nov 18, 2024
25 checks passed
@milianw milianw deleted the fix-broken-flamegraph branch November 18, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flamegraph is not repainted correctly when zooming out
2 participants