fix: also support ' and , as branch visualization characters

My objdump from arch uses these chars now, so let's support them too
KDAB · Sep 2, 2024 · f326ef0 · f326ef0
1 parent 221d60e
commit f326ef0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/resultsdisassemblypage.cpp b/src/resultsdisassemblypage.cpp
@@ -142,9 +142,11 @@ class BranchDelegate : public QStyledItemDelegate
                 startHorizontalLine(x);
                 verticalLine();
                 break;
+            case '\'':
             case '\\':
                 topRightEdge();
                 break;
+            case ',':
             case '/':
                 bottomLeftEdge();
                 break;

diff --git a/tests/modeltests/tst_disassemblyoutput.cpp b/tests/modeltests/tst_disassemblyoutput.cpp
@@ -243,9 +243,10 @@ private slots:
         QVERIFY(result.errorMessage.isEmpty());
 
         auto isValidVisualisationCharacter = [](QChar character) {
-            const static auto validCharacters = std::initializer_list<QChar> {
-                QLatin1Char(' '), QLatin1Char('\t'), QLatin1Char('|'), QLatin1Char('/'), QLatin1Char('\\'),
-                QLatin1Char('-'), QLatin1Char('>'),  QLatin1Char('+'), QLatin1Char('X')};
+            const static auto validCharacters =
+                std::initializer_list<QChar> {QLatin1Char(' '),  QLatin1Char('\t'), QLatin1Char('|'), QLatin1Char('/'),
+                                              QLatin1Char('\\'), QLatin1Char('-'),  QLatin1Char('>'), QLatin1Char('+'),
+                                              QLatin1Char('X'),  QLatin1Char(','),  QLatin1Char('\'')};
 
             return std::any_of(validCharacters.begin(), validCharacters.end(),
                                [character](auto validCharacter) { return character == validCharacter; });