cxx-qt-gen: add support for passing in CfgEvaluator #1144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
force-pushed
the
1133-cfg-evaulator
branch
5 times, most recently
from
bb64d6c to
457c3eb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1144 +/- ##
===========================================
- Coverage 100.00% 98.90% -1.10%
===========================================
Files 71 73 +2
Lines 11967 12569 +602
===========================================
+ Hits 11967 12431 +464
- Misses 0 138 +138 ☔ View full report in Codecov by Sentry. |
ahayzen-kdab
force-pushed
the
1133-cfg-evaulator
branch
from
457c3eb to
3bd6b79
Compare
ahayzen-kdab
force-pushed
the
1133-cfg-evaulator
branch
11 times, most recently
from
9d635b6 to
8fbd574
Compare
ahayzen-kdab
changed the title
ahayzen-kdab
commented
Jan 24, 2025
| *self = CfgExpr::All(vec![prev, expr]); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
it's unclear what codecov is complaining about on these lines 🤔
ahayzen-kdab
force-pushed
the
1133-cfg-evaulator
branch
5 times, most recently
from
619cc9d to
f1d9b5f
Compare
ahayzen-kdab
force-pushed
the
1133-cfg-evaulator
branch
2 times, most recently
from
a6a08c8 to
b9a70db
Compare
ahayzen-kdab
force-pushed
the
1133-cfg-evaulator
branch
from
b9a70db to
f986189
Compare
|
Going to use #1168 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.