Merge pull request #349 from K3D-tools/devel

Additional line when using 'simple' shader in k3d.lines #348
K3D-tools · May 20, 2022 · 64e9f3a · 64e9f3a
2 parents f3e4c8e + a23e16f
commit 64e9f3a
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 5 deletions.
diff --git a/RELEASE.md b/RELEASE.md
@@ -11,4 +11,4 @@ cd js
 grunt build
 npm publish
 cd ../docs
-make html
+make html
diff --git a/js/package.json b/js/package.json
@@ -1,6 +1,6 @@
 {
   "name": "k3d",
-  "version": "2.13.0",
+  "version": "2.13.1",
   "description": "3D visualization library",
   "author": "k3d team",
   "main": "src/index.js",

diff --git a/js/src/providers/threejs/objects/LinesSimple.js b/js/src/providers/threejs/objects/LinesSimple.js
@@ -22,7 +22,7 @@ module.exports = {
         const colorRange = config.color_range;
         const colorMap = (config.color_map && config.color_map.data) || null;
         const attr = (config.attribute && config.attribute.data) || null;
-        const object = new THREE.Line(geometry, material);
+        const object = new THREE.LineSegments(geometry, material);
         const modelMatrix = new THREE.Matrix4();
         const vertices = config.vertices.data;
         const indices = config.indices.data;
@@ -31,7 +31,7 @@ module.exports = {
         let positions = [];
         let attribute = [];
         let colors = [];
-        let jump = config.indices_type == 'segment' ? 2 : 3;
+        let jump = config.indices_type === 'segment' ? 2 : 3;
         let offsets;
 
         let verticesCount = vertices.length / 3;

diff --git a/k3d/test/references/lines_simple_attribute_segment.png b/k3d/test/references/lines_simple_attribute_segment.png
diff --git a/k3d/test/references/lines_simple_colors.png b/k3d/test/references/lines_simple_colors.png
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "k3d",
-  "version": "2.13.0",
+  "version": "2.13.1",
   "description": "3D visualization library",
   "keywords": [
     "jupyter",