-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to explicit imports of names from packages #748
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e956bb3
Switch to explicit imports
dmbates 14bfeca
Committed the wrong file.
dmbates 188f24b
Bump patch version number and add NEWS item.
dmbates 1698bd2
Add imports from PrecompileTools; tests with ExplicitImports.
dmbates 54707c5
Read and follow suggestion in ExplicitImports docs.
dmbates 274a71a
Incorporate suggestions by palday and ericphanson
dmbates 12da578
Update NEWS.md
dmbates d4ff897
Remove unused indirect dependency.
dmbates File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Switch to explicit imports
- Loading branch information
commit e956bb3241e874f063ba86286935c8ed03683254
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Module MixedModels is not relying on any implicit imports. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we already have
StaticArrays
, can we grabSVector
from there? I know this doesn't increase our total dependency load, but it's another thing to track.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filed ericphanson/ExplicitImports.jl#24 fyi. I think though if you do
using StaticArrays: SVector
, then it won't complain about the implicit import. But when it makes suggestions, it always does the "defining" module.