Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to explicit imports of names from packages #748

Merged
merged 8 commits into from
Mar 4, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Switch to explicit imports
  • Loading branch information
dmbates committed Mar 1, 2024
commit e956bb3241e874f063ba86286935c8ed03683254
1 change: 1 addition & 0 deletions MixedModels_explicit_imports.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Module MixedModels is not relying on any implicit imports.
2 changes: 2 additions & 0 deletions Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ ProgressMeter = "92933f4c-e287-5a05-a399-4b506db050ca"
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"
StaticArraysCore = "1e83bf80-4336-4d27-bf5d-d5a4f845583c"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we already have StaticArrays, can we grab SVector from there? I know this doesn't increase our total dependency load, but it's another thing to track.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filed ericphanson/ExplicitImports.jl#24 fyi. I think though if you do using StaticArrays: SVector, then it won't complain about the implicit import. But when it makes suggestions, it always does the "defining" module.

Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
StatsAPI = "82ae8749-77ed-4fe6-ae5f-f523153014b0"
StatsBase = "2913bbd2-ae8a-5f71-8c99-4fb6c76f3a91"
Expand Down Expand Up @@ -50,6 +51,7 @@ Random = "1"
SparseArrays = "1"
StableRNGs = "0.1, 1"
StaticArrays = "0.11, 0.12, 1"
StaticArraysCore = "1"
Statistics = "1"
StatsAPI = "1.5"
StatsBase = "0.31, 0.32, 0.33, 0.34"
Expand Down