-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ma86 #82
Open
bjack205
wants to merge
18
commits into
JuliaSmoothOptimizers:main
Choose a base branch
from
bjack205:ma86
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ma86 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@bjack205 Many thanks. Could you please remove the commits that have already been merged, remove the merge commits? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ma86 algorithm.
The wrapper is slightly different than the existing ma97 one. I personally think it's cleaner, keeping the wrappers around the
ccall
s looking nearly identical to the C functions, and then creating a few convenience methods to call those. If you like this, I can submit another PR that updates the ma97 interface to be similar. I personally found the ma97 wrapper a bit confusing since it used different names and call signatures from the C wrapper. We can keep the existing methods to not break any existing code, or simply deprecate them.As a quick summary, the proposed API for Ma86 looks like this (as detailed in the docstring):
Or
Or a wrapper around the LinearAlegbra methods: