[AUTO] JuliaFormatter.jl run #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dpo
reviewed
Oct 6, 2022
src/hsl_mc21.jl
Outdated
| ccall((:mc21ad_, libhsl_mc21), | ||
| Nothing, | ||
| (Ref{Int32}, Ptr{Int32}, Ref{Int32}, Ptr{Int32}, Ptr{Int32}, Ptr{Int32}, Ref{Int32}, Ptr{Int32}), | ||
| n , icn , licn , ip , lenr , iperm , numnz , iw) |
There was a problem hiding this comment.
@amontoison Why is lenr a Ptr and not a Ref like the other integers in this call?
Also, should we add some markup to prevent this kind of silly formatting?
There was a problem hiding this comment.
Yes, we should add some
#! format: off
#! format: onaround the ccall(s).
There was a problem hiding this comment.
I use Ptr because lenr is a vector.
github-actions
bot
force-pushed
the
auto-juliaformatter-pr
branch
from
5100a94 to
350824f
Compare
|
JuliaFormatter will open a new PR after #121 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action