Add multi-precision support #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First version should 0.1.0
…s/fix-version Version 0.1.0
…s/PR-Codecov Pr codecov
* Cleaning the Todos --------- Co-authored-by: tmigot <[email protected]>
Co-authored-by: tmigot <[email protected]>
This reverts commit f92d0db.
fixing a typo in the readme
…s/farhadrclass-patch-1 Update README.md
|
|
||
| Tests FluxNLPModel loader and NN device consistency. | ||
| """ | ||
| function test_devices_consistency(chain_ANN::Vector{T},data_train,data_test) where {T <: Chain} |
There was a problem hiding this comment.
why do we need this? loader and training can be on different machine or type, we just need to adjust them on the running
| @@ -0,0 +1,78 @@ | |||
| # test example taken from Flux quickstart guide ([https://fluxml.ai/Flux.jl/stable/models/quickstart/](https://fluxml.ai/Flux.jl/stable/models/quickstart/)) | |||
There was a problem hiding this comment.
I suggest having couple of more tests to include one or 2 iteration with training and updating the weights
There was a problem hiding this comment.
I think we can add this to my PR, I will have it ready soon but the tests look good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.