Upgrade ADNLPModels.jl for SparseMatrixColoring.jl v0.4.0 #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdalle
requested changes
Aug 13, 2024
src/sparse_hessian.jl
Outdated
| colors = column_colors(result) | ||
| groups = column_groups(result) | ||
| ncolors = length(groups) | ||
| star_set = result.star_set |
There was a problem hiding this comment.
same remark here about the star_set
amontoison
force-pushed
the
smt-upgrade
branch
from
13a399d to
5df3051
Compare
gdalle
requested changes
Aug 15, 2024
amontoison
force-pushed
the
smt-upgrade
branch
from
5df3051 to
49c8274
Compare
|
amontoison
merged commit d47b385
into
JuliaSmoothOptimizers:main
36 of 38 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @gdalle