-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a symmetric coloring for the computation of sparse Hessians #271
Conversation
e356cc7
to
55de379
Compare
5004c7e
to
63e4833
Compare
Benchmark resultJudge resultBenchmark Report for /home/runner/work/ADNLPModels.jl/ADNLPModels.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/ADNLPModels.jl/ADNLPModels.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/ADNLPModels.jl/ADNLPModels.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
My recommendation would be to use the decompression functions provided with SparseMatrixColorings:
The latter is more efficient when you provide an additional argument, namely the set of stars resulting from the star coloring. This object can be accessed by replacing In the API of the decompression functions:
You can take a look at the following files in DI to see how these functions are used: |
22e0e49
to
3ad77de
Compare
Benchmark resultJudge resultBenchmark Report for /home/runner/work/ADNLPModels.jl/ADNLPModels.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/ADNLPModels.jl/ADNLPModels.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/ADNLPModels.jl/ADNLPModels.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
You have the wrong version of SparseMatrixColorings in the benchmark manifest |
I need to do like yesterday and bump |
70d67e3
to
99ebc68
Compare
If we have the same results after the benchmarks, I merge the PR and do a new release. |
Hell yeah! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #271 +/- ##
==========================================
+ Coverage 95.22% 95.53% +0.31%
==========================================
Files 13 13
Lines 1445 1546 +101
==========================================
+ Hits 1376 1477 +101
Misses 69 69 ☔ View full report in Codecov by Sentry. |
Benchmark resultJudge resultBenchmark Report for /home/runner/work/ADNLPModels.jl/ADNLPModels.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/ADNLPModels.jl/ADNLPModels.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/ADNLPModels.jl/ADNLPModels.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
close #258
Related to #246