-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize sparse AD #257
Closed
amontoison
wants to merge
2
commits into
JuliaSmoothOptimizers:main
from
amontoison:optimization_sparse
Closed
Optimize sparse AD #257
amontoison
wants to merge
2
commits into
JuliaSmoothOptimizers:main
from
amontoison:optimization_sparse
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
==========================================
+ Coverage 95.50% 95.53% +0.02%
==========================================
Files 13 13
Lines 1535 1545 +10
==========================================
+ Hits 1466 1476 +10
Misses 69 69 ☔ View full report in Codecov by Sentry. |
amontoison
force-pushed
the
optimization_sparse
branch
from
July 7, 2024 03:57
eb558f4
to
7abcf98
Compare
@tmigot Still not working :( |
amontoison
added
run Jacobian benchmark
run Hessian benchmark
and removed
run Jacobian benchmark
run Hessian benchmark
labels
Jul 10, 2024
amontoison
force-pushed
the
optimization_sparse
branch
from
July 10, 2024 01:30
7abcf98
to
b11f4a4
Compare
@tmigot Where are uploaded the results of the benchmarks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dcolors
such thatdcolors[c]
is an array of the components ofvals
that will be computed by the directional derivative associated with colorc
.We don't need anymore for each color to iterate over all variables to recover which column should be updated.