Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: OndaEDF v0.13.0 #124113

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

JuliaRegistrator
Copy link
Contributor

## Breaking changes:

- In order to support EDF.jl 0.8, the return type of the generated plans has been changed to V3. V3 expands the field `sample_per_record` from `Int16` to `Int32`.
- Support for EDF.jl < 0.8 has been dropped.
- These changes should be transparent to the user, unless you're depending on precise concrete types.

UUID: e3ed2cd1-99bf-415e-bb8f-38f4b42a544e
Repo: https://github.com/beacon-biosignals/OndaEDF.jl.git
Tree: c87e41c8567d9cf0e4f63d4eda38c02b2f426db9

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
JuliaRegistrator referenced this pull request in beacon-biosignals/OndaEDF.jl Jan 31, 2025
This upgrades OndaEDF.jl to EDF.jl 0.8 (c.f. beacon-biosignals/EDF.jl#92), which expands the field `sample_per_record` from `Int16` to `Int32`, mandating the creation of a new `PlanV3` and `FilePlanV3` that can accommodate this wider type.

Co-authored-by: Phillip Alday <phillip.alday@beacon.bio>
Copy link
Contributor

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. AutoMerge Guidelines are all met! ✅

Your new version registration met all of the guidelines for auto-merging and is scheduled to be merged in the next round (~20 minutes).

2. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@JuliaTagBot JuliaTagBot merged commit bbf4fa8 into master Jan 31, 2025
20 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-ondaedf-e3ed2cd1-v0.13.0-13328f38df branch January 31, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants