-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timedelta, timedelta64 and datetime64 plus respective conversions #509
Open
hhaensel
wants to merge
27
commits into
JuliaPy:main
Choose a base branch
from
hhaensel:hh-timedelta64
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+432
−37
Open
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
093bdcb
add support for `@py from <module> import`
c63ab23
Merge branch 'cjdoris:main' into main
hhaensel 5a65a52
Merge branch 'main' of https://github.com/hhaensel/PythonCall.jl
hhaensel 5740b59
support timedelta, timedelta64, datetime64 and respective conversions
hhaensel f897600
fix week kw in pytimedelta64, typo (space) in builtins
hhaensel 1e8d410
correct handling of count in 64-bit conversion rules
b3cc79f
Merge remote-tracking branch 'origin/main' into hh-timedelta64
hhaensel 9dfc0dd
Apply suggestions from code review
hhaensel a3a2b97
Apply suggestions from code review part II
hhaensel daf9759
reviewers suggestions part III
hhaensel 60e0daa
Merge branch 'JuliaPy:main' into hh-timedelta64
hhaensel 7391b8d
add tests for pytimedelta
8f28567
fix micro/millisecond in pytimedelta,
46efe53
add tests for pytimedelta, pytimedelta64 and conversion of pytimedelt…
d36c113
fix pytimdelta(years/months=0), add pydatetime64(::Union{Date, DateTi…
hhaensel 66459c6
add tests for pytimedelta64, pydatetime64
hhaensel 3c51b54
support unitless timedelta64, keep unit per default, add keyword cano…
fac1ef8
add tests for timedelta64 canonicalize
d00a788
Merge branch 'JuliaPy:main' into hh-timedelta64
hhaensel 5abcf1d
add CondaPkg and DataFrames as extras in Project.toml
34f35ce
fix pandas testing
9864173
fix compat with julia < 1.8
3148bae
specialize Base.convert(::<:Period, CompoundPeriod) for julia < 1.8
94b47df
change CondaPkg environment
f66f526
fix test/Project.toml, adapt runtests.jl
e9277ef
change order of args of pytimedelta; add docstrings for pytimedelta, …
d93e99a
remove `@py`method for python-style imports
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix week kw in pytimedelta64, typo (space) in builtins
commit f897600b25fedc31ce2b3c378dca61d68d1e95b0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment
Should be presented to the user as a descriptive error message rather than a comment in the function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the comment isn't clear enough.
Python throws a well understandable descriptive error in case of wrong usage, so no need for us to do so. Agree?