WIP: keyword arguments for parallel_for and synchronize #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilipFackler
requested review from
miniskar,
pedrovalerolara and
williamfgc
|
Test this please |
williamfgc
reviewed
Feb 10, 2025
| function JACC.synchronize(::AMDGPUBackend; stream = default_stream()) | ||
| AMDGPU.synchronize(stream) | ||
| end | ||
|
|
||
| function JACC.parallel_for( |
There was a problem hiding this comment.
Is this absorbing the generic API? Would it make sense to overload rather than extend? Since this is a specialized case and keyword arguments can add overhead to quick kernel launching. Would be good to test in apps like Lulesh with those characteristics. Thoughts?
There was a problem hiding this comment.
Not sure how this question applies to synchronize. But for parallel_for: yes I included these keywords in the current implementation. I could implement a separate API, but the keyword arguments would need to be handled differently (it would conflict with the vararg x...). This would be easy enough. I'll try it that way on a separate branch so we can compare.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.