Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add segre and warped segre manifold #755

Merged
merged 42 commits into from
Dec 20, 2024
Merged
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
a35e472
add segre and warped segre manifold
Oct 2, 2024
9139574
added formulas to Segre manifold documentation
Oct 4, 2024
78ca0fd
Merge branch 'master' into sjacobsson/serge
kellertuer Oct 6, 2024
fd384fb
Setup docs, fix a few type errors, runs formatter.
kellertuer Oct 6, 2024
b34518e
Fix a bit of tests, version number and docs.
kellertuer Oct 6, 2024
b1417c1
Comment our tests so CI runs at least.
kellertuer Oct 6, 2024
2b2da05
runs formatter.
kellertuer Oct 6, 2024
f0d6624
added formulas in documentation
Oct 10, 2024
fc7a1b2
wrote tests for the Segre and the Segre with warped metric
Dec 6, 2024
d05eb4c
Merge branch 'master' into master
sjacobsson Dec 6, 2024
09e5207
formatting
Dec 6, 2024
6d6286e
Merge branch 'master' of github.com:sjacobsson/Manifolds.jl
Dec 6, 2024
269b137
Merge branch 'master' into sjacobsson/serge
kellertuer Dec 16, 2024
53a040e
fix Ronny's comments
Dec 17, 2024
0ac4c61
Merge branch 'master' into master
sjacobsson Dec 17, 2024
85919d2
Add test that get_coordinates(::Segre,...) and get_vector(::Segre,...…
Dec 17, 2024
8b90eb4
Merge remote-tracking branch 'refs/remotes/origin/master'
Dec 17, 2024
acfc752
Remove todos for Segre.
Dec 18, 2024
e6bf4a6
Fix inconsistencies in docstrings for Segre.
Dec 18, 2024
7079eef
formatting
Dec 18, 2024
1a2ce37
Fix codecov.
Dec 18, 2024
da09f54
A bit of markdown formatting, use UTF8 symbols where useful (in VS co…
kellertuer Dec 18, 2024
92ea877
Fix a typo.
kellertuer Dec 18, 2024
07dca08
Sponsor a nice show function.
kellertuer Dec 18, 2024
4620c18
Ooops. Deleted a parameter too much.
kellertuer Dec 18, 2024
f3a7f50
reduce magic numbers in testing and replace them by a bit more struct…
kellertuer Dec 19, 2024
c958bd2
Add Simon to the about page, adapt menu, wrap Segre test in a testset.
kellertuer Dec 19, 2024
2a1426b
Fix / re-add embed for tangent vectors. Unify test formatting
kellertuer Dec 19, 2024
e956159
Add link to Segre.
kellertuer Dec 19, 2024
25ece44
Move docstring from check_point and check_vector to is_point and is_v…
Dec 19, 2024
82f2c72
Test coverage for case in closest_representative! where given points …
Dec 19, 2024
0dab4f4
Update zenodo metadata.
kellertuer Dec 19, 2024
bd66d56
Add line about constructor in docstring for WarpedMetric.
Dec 19, 2024
e0e61a2
Actually test coverage for case in closest_representative! where give…
Dec 19, 2024
d11971c
Fix documentation
kellertuer Dec 19, 2024
5d8a4ba
bump documenter CI to Julia 1.11 as well.
kellertuer Dec 19, 2024
f41fece
add a show method for the warped metric so it prints nicer on REPL
kellertuer Dec 20, 2024
1f29ba8
Code golf in the segre tests. Also change a bunch of variable names a…
Dec 20, 2024
6d0db08
formatting
Dec 20, 2024
36b6afa
add news entry and date.
kellertuer Dec 20, 2024
341e913
Merge branch 'master' of github.com:sjacobsson/Manifolds.jl into sjac…
kellertuer Dec 20, 2024
a2413c5
small commit
Dec 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add a show method for the warped metric so it prints nicer on REPL
kellertuer committed Dec 20, 2024
commit f41fece46e8e2bc71b172fda35985310a9aea729
4 changes: 4 additions & 0 deletions src/manifolds/SegreWarpedMetric.jl
Original file line number Diff line number Diff line change
@@ -27,12 +27,12 @@
return WarpedMetric{A}()
end

function connected_by_geodesic(

Check warning on line 30 in src/manifolds/SegreWarpedMetric.jl

Codecov / codecov/patch

src/manifolds/SegreWarpedMetric.jl#L30

Added line #L30 was not covered by tests
M::MetricManifold{ℝ,Segre{ℝ,V},WarpedMetric{A}},
p,
q,
) where {V,A}
return connected_by_geodesic(M.manifold, p, q)

Check warning on line 35 in src/manifolds/SegreWarpedMetric.jl

Codecov / codecov/patch

src/manifolds/SegreWarpedMetric.jl#L35

Added line #L35 was not covered by tests
end

function closest_representative!(
@@ -308,6 +308,10 @@
(inner(M, p, u, u) * inner(M, p, v, v) - inner(M, p, u, v)^2)
end

function show(io::IO, ::WarpedMetric{A}) where {A}
return print(io, "WarpedMetric($A)")
end

function spherical_angle_sum(
M::MetricManifold{ℝ,Segre{ℝ,V},WarpedMetric{A}},
p,

Unchanged files with check annotations Beta

``\mathcal{S}`` is not a complete manifold, i.e. not every pair `p` and `q` of points are connected by a geodesic in ``\mathcal{S}``.
`connected_by_geodesic(M, p, q)` returns `true` if two points, `p` and `q`, are connected by a geodesic, and otherwise returns `false`.
"""
function connected_by_geodesic(M::Segre{ℝ,V}, p, q) where {V}
closest_representative!(M, q, p)
return spherical_angle_sum(M, p, q) < pi

Check warning on line 123 in src/manifolds/Segre.jl

Codecov / codecov/patch

src/manifolds/Segre.jl#L121-L123

Added lines #L121 - L123 were not covered by tests
end
@doc raw"""