Short channel matching for julia command #836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This error message is interesting, but upon reflection seems pretty good. It would be slightly better if the message explicitly mentioned that |
LilithHafner
reviewed
Jul 3, 2024
LilithHafner
reviewed
Jul 3, 2024
LilithHafner
reviewed
Jul 3, 2024
LilithHafner
reviewed
Jul 3, 2024
LilithHafner
approved these changes
Jul 3, 2024
|
Would be good to add a test, too |
|
Needs docs |
|
I think I've finally am getting clarity what I'm thinking about this, see #830. |
|
I'm closing this for now, as I don't think we will go with this kind of solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #830
This pull request introduces the feature of short channel matching for the Julia command. Users can now launch alpha, beta, LTS, release, and nightly versions by specifying their respective short names: "a" for alpha, "b" for beta, "l" for LTS, "r" for release, and "n" for nightly.