Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove fence that GC change made unnecessary #56986

Merged
merged 1 commit into from
Jan 10, 2025
Merged

remove fence that GC change made unnecessary #56986

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/cgutils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4463,8 +4463,6 @@ static void emit_memory_zeroinit_and_stores(jl_codectx_t &ctx, jl_datatype_t *ty
auto len_store = ctx.builder.CreateAlignedStore(nel, len_field, Align(sizeof(void*)));
auto aliasinfo = jl_aliasinfo_t::fromTBAA(ctx, ctx.tbaa().tbaa_memorylen);
aliasinfo.decorateInst(len_store);
//This avoids the length store from being deleted which is illegal
ctx.builder.CreateFence(AtomicOrdering::Release, SyncScope::SingleThread);
// zeroinit pointers and unions
if (zi) {
Value *memory_ptr = ctx.builder.CreateStructGEP(ctx.types().T_jlgenericmemory, decay_alloc, 1);
Expand Down
Loading