Backport "serialization: fix relocatability bug" to 1.10 #56973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm this fixes #56947 |
vtjnash
approved these changes
Jan 6, 2025
|
@KristofferC the failures look odd, but I haven't followed the backports closely to judge if this introduces anything new. |
|
At a quick glance, doctest failure is also on the backport branch, as is the trimming one (that job should simply not run before Julia v1.12), but the test failures on this branch look real |
Actually, the macOS failures are also in #57005 (another PR backporting changes to the v1.10 branch) |
(cherry picked from commit cf4f1ba)
vchuravy
force-pushed
the
vc/backport-1.10-54738
branch
from
541bc5f to
787f52c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit cf4f1ba)