Make write(IO, Char) actually return the amount of printed bytes inst…

…ead of the attempted written bytes. (#56980)
JuliaLang · Jan 10, 2025 · 6ac351a · 6ac351a
1 parent b80dd58
commit 6ac351a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/base/io.jl b/base/io.jl
@@ -864,11 +864,10 @@ end
 
 function write(io::IO, c::Char)
     u = bswap(reinterpret(UInt32, c))
-    n = 1
+    n = 0
     while true
-        write(io, u % UInt8)
+        n += write(io, u % UInt8)
         (u >>= 8) == 0 && return n
-        n += 1
     end
 end
 # write(io, ::AbstractChar) is not defined: implementations

diff --git a/test/iobuffer.jl b/test/iobuffer.jl
@@ -399,3 +399,9 @@ end
     io = IOBuffer(data)
     @test read(io) == data
 end
+
+@testset "Writing Char to full buffer" begin
+    io = IOBuffer(;maxsize=1)
+    write(io, 'a')
+    @test write(io, 'a') == 0
+end