Specialize remotecall_pool(remotecall) to wait for the remotecall #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #120 +/- ##
==========================================
+ Coverage 79.19% 79.26% +0.06%
==========================================
Files 10 10
Lines 1923 1934 +11
==========================================
+ Hits 1523 1533 +10
- Misses 400 401 +1 ☔ View full report in Codecov by Sentry. |
|
(bump) |
|
Thanks for the PR. Unfortunately, I will not be able to review this. |
JamesWrigley
force-pushed
the
workerpool-remotecall
branch
from
623379f to
22bbd5e
Compare
Otherwise the worker would prematurely be put back into the pool, causing oversubscription. Also added a warning about oversubscription to the docstring for `remote_do(f, ::AbstractWorkerPool)`.
JamesWrigley
force-pushed
the
workerpool-remotecall
branch
from
22bbd5e to
89b4cd3
Compare
IanButterworth
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the worker would prematurely be put back into the pool, causing oversubscription. Also added a warning about oversubscription to the docstring for
remote_do(f, ::AbstractWorkerPool).Fixes #81. Cherry-picked from JuliaParallel/DistributedNext.jl#20.