Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow the specs more closely, switch to JWTs.jl, and fix the tests #9
Follow the specs more closely, switch to JWTs.jl, and fix the tests #9
Changes from all commits
8565e66
63bed64
c9c6d93
9a3d972
c4705ec
7d627ab
a78abb5
f485878
a9ccf76
6828a66
337cccb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 53 in src/backend_services.jl
Codecov / codecov/patch
src/backend_services.jl#L53
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use struct-mapping instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My initial implementation used struct mapping but it felt a bit too verbose since it requires a struct for every level of this nested structure.
Check warning on line 99 in src/backend_services.jl
Codecov / codecov/patch
src/backend_services.jl#L99
Check warning on line 102 in src/backend_services.jl
Codecov / codecov/patch
src/backend_services.jl#L102
Check warning on line 105 in src/backend_services.jl
Codecov / codecov/patch
src/backend_services.jl#L105
This file was deleted.